Add System.Net.Http ServerCertificateCustomValidationCallback ILLink Suppression #58456
Conversation
…ck ILLink Suppression
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #57537 During #57555, it was unclear what the correct suppression syntax would be for a return type of
|
steveisok
changed the title
|
cc: @eerhardt |
mdh1418
deleted the
fix_ServerCertificateCustomValidationCallback_PNSE_Android
branch
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1190872599 |
| @@ -141,6 +141,18 @@ | |||
| <property name="Target">M:System.Net.Http.HttpClientHandler.SetMaxAutomaticRedirections(System.Int32)</property> | |||
| <property name="Justification">The Xamarin.iOS and Mono.Android libraries are not present when running the trimmer analysis during our build. A consuming application will get a warning if these libraries aren't present when trimming the full app.</property> | |||
| </attribute> | |||
| <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute"> | |||
There was a problem hiding this comment.
@steveisok @mdh1418 - this is a pretty massive xml suppression file. It may make sense to make it AnyMobile specific and only use it when building for AnyMobile targets. That way we don't inadvertently suppress warnings when we shouldn't be.
There was a problem hiding this comment.
@mdh1418 Can you do a follow up PR w/ Eric's suggestion?
ghost
locked as resolved and limited conversation to collaborators
Fixes #57537
During PR #57555, it was unclear what the correct suppression syntax would be for a return type of
Func<HttpRequestMessage, X509Certificate2?, X509Chain?, SslPolicyErrors, bool>. With some helpful switches to generate the right warning suppression syntax via--generate-warning-suppressions xmlinRuntimePackILLinkArgs, this PR adds the correct warning suppression.